Page 7 of 16 FirstFirst ... 23456789101112 ... LastLast
Results 91 to 105 of 238

Thread: Narrowband Tuning Tool

  1. #91
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    Quote Originally Posted by dud View Post
    I included a copy of the modified dictionary file in the previous attachment.

    Looking forward to the upcoming features. So glad we have talented people like you willing to share.
    oh alrighty i'll have a look

    this is kind of a side project to another similar program i'm writing for work. it also parses huge amounts of csv data into usable structures and does analysis on it, so i can share a bunch of functions and ideas, kill two birds with one stone. otherwise i might not be writing it.

  2. #92
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    fyi to define your parameter,

    1. add a new unique value to definition.h's STDMAP_* enumeration, while leaving STDMAP_N_VALUES at the end. this gives us a numerical value instead of a lookup. the 'dictionary' uses this.

    Code:
      enum {
        STDMAP_LBLM = 1,
        STDMAP_RBLM,
        STDMAP_LINT,
       ...
        STDMAP_TPS,
        STDMAP_FOO,
        STDMAP_N_VALUES
      };
    2. add a new case to defintion::name_of_parameter. this translates the above enumeration to a string used both in the user interface (so the user knows what they're trying to match up to), and the dictionary.txt file.

    Code:
      case STDMAP_KNOCKCOUNT:
        return QString("Knock Counter");
        break;
      case STDMAP_TPS:
        return QString("TPS%");
        break;
      case STDMAP_FOO:
        return QString("Foo");
        break;
    3. add a line starting with Foo to dictionary.txt (you need to redefine Foo here as well, since the first field doesn't actually count for a lookup value), these are not case sensitive:

    Code:
    Foo,FOO,bar,etc,other definitions,blahblahblah
    4. add a definition to automatic filter detection function in mainwindow.cpp (MainWindow::populate_filters()), see data_filter.h for possible filter operations.

    Code:
    add_filter(definition::STDMAP_FOO,data_filter::GREATERTHAN,1.2345);

  3. #93

  4. #94
    Fuel Injected! dud's Avatar
    Join Date
    Jan 2016
    Age
    55
    Posts
    30
    Excellent. The "Remember" feature works great.

    Believe it or not I actually had the "definition" and "dictionary" files edited as you described. The "mainwindow" file is what I was missing. Edited it and it worked.

    I still feel kinda like a cow trying to read the newspaper when looking at this stuff though. :-)

    I'll try compile it in linux later. Gotta get ready to go to work now.

  5. #95
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    the only ui hitch is that when you remember something, it no longer uses filter autodetection on startup. you have to click the auto button if you want that to happen, and there's no 'clear' function.

    just fyi i saw you added some true/false identifiers to your dictionary to deal with alternate cases

    that should not be necessary as the dictionary is generally case insensitive (i convert both dictionary and search entries to uppercase)

    .. unless you've observed differently, i haven't actually tested it much

    Believe it or not I actually had the "definition" and "dictionary" files edited as you described. The "mainwindow" file is what I was missing. Edited it and it worked.
    easy misunderstanding due to my weirdo use of classes. mainwindow.c handles the propogation/creation/deletion of the list of filters, the filter class itself is simply a ui element that contains isolated data about the filter and a front end to edit it (mainwindow contains multiple filters, but filters have no knowledge of each other whatsoever), and to further confuse matters, the list of filters is actually contained in the analysis class, since mainwindow doesn't use the filters, only manages them.

    i do hate object oriented programming, so i think i subconsciously make bad design decisions on purpose.

  6. #96
    Fuel Injected!
    Join Date
    Dec 2016
    Location
    Colorado
    Age
    39
    Posts
    120
    Quote Originally Posted by steveo View Post
    cool! those are some huge trims, can you send me that log? that might be a good test case to see if my algorithm is tuned properly..
    Here is the csv log file that I ran through. This was the first change from the stock bin. Please let me know if it looks to be doing right. Before this one tune I would run rich all the time, 105-120..now Im seeing some in the low to mid 130's at highway steady speeds. Im going to keep running logs through. Great tool, and thanks for making this for everyone!
    Attached Files Attached Files

  7. #97
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    your results look good. i also see about the same data but a bit broader from my own analysis routine to the 'loose cell' routine which is a good sign. it would definitely be good to know if it ends up making your trim table work properly if you keep running it

    Quote Originally Posted by Stokes1114 View Post
    Here is the csv log file that I ran through. This was the first change from the stock bin. Please let me know if it looks to be doing right. Before this one tune I would run rich all the time, 105-120..now Im seeing some in the low to mid 130's at highway steady speeds. Im going to keep running logs through. Great tool, and thanks for making this for everyone!

  8. #98
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    new version, biggest new thing is that when you select a custom mapping, it remembers and priorities it over auto-detection.

    http://fbodytech.com/trimalyzer/trimalyzer-download/

    0.4b BETA:
    - support dark ui (see advanced settings)
    - auto-detect filters on startup again (must manually press recall)
    - remember the last mapping selected and prioritize it over the dictionary

  9. #99
    Electronic Ignition!
    Join Date
    Jul 2012
    Age
    54
    Posts
    14
    First i'd like to say thanks for making this tool, it is immensely helpfull and saves me from cutting and pasting to and from spreadsheets. I do most of my tuning and prom burning on an old xp laptop and when i tried to run this on that machine i get the attached error. Any idea what i can do to fix it?2017-03-29 15_43_42-Greenshot.jpg

  10. #100
    Fuel Injected!
    Join Date
    Dec 2016
    Location
    Colorado
    Age
    39
    Posts
    120
    3-29-17Trim.PNGHere is my log file from my drive home, and a pic of the results. This program is so nice..So much faster than using spreadsheets. For me at least, since Im no pro at excel. Could you explain how the colors relate to the severity?
    Attached Files Attached Files
    Last edited by Stokes1114; 03-30-2017 at 02:51 AM.

  11. #101
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    glad you like it!!

    Could you explain how the colors relate to the severity?
    blue ideal, red rich, green lean. i based the color scheme on datamaster (since many people are accustomed to them)

    now, i wouldn't go ahead and insist on what's 'ideal' and 'rich' and 'lean', so in the advanced settings, you're free to change TUNE_VISUAL_LEAN_TRIM and TUNE_VISUAL_RICH_TRIM to suit your tastes. it is percentage trim based. defaults are > 103%+ lean and < 97% rich.

    I do most of my tuning and prom burning on an old xp laptop and when i tried to run this on that machine i get the attached error. Any idea what i can do to fix it?
    unfortunately i write my software using libraries that are incompatible with windows XP, so it wont work. i also have an xp tuning netbook, so i feel your pain, but the advantages of using modern versions of QT are just too great for me. sorry

  12. #102
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    new version:

    http://fbodytech.com/trimalyzer/trimalyzer-download/

    0.5b BETA:
    - redefine ui, now a single window with context switching
    - a few other misc ui changes
    - add per-filter statistics printout on analysis
    - fix 'about' screen

  13. #103
    Fuel Injected! dud's Avatar
    Join Date
    Jan 2016
    Age
    55
    Posts
    30
    Lovin the polish. The clean output in the parser log is a very nice touch.

  14. #104
    Fuel Injected!
    Join Date
    Aug 2015
    Age
    44
    Posts
    46
    I'd love to test this out even though I got my WB installed and has help tremendously. I'm still learning and love to dial in my VE a little more easily. The only problem is I run in SD OL mode. I still get NB/WB o2 feedback but don't get BLM/INT due to OL as you know. Looks like a great program though!

  15. #105
    LT1 specialist steveo's Avatar
    Join Date
    Aug 2013
    Posts
    4,007
    if ya have wideband output in your csv file, use 100% mode and use the wideband value in place of the trim value, it'll do it

Similar Threads

  1. LS1 Flash Tool Released
    By antus in forum OBDII Tuning
    Replies: 118
    Last Post: 4 Weeks Ago, 07:02 PM
  2. Scan Tool Data Help
    By Kaweh in forum TunerPro Tuning Talk
    Replies: 1
    Last Post: 05-12-2015, 12:15 AM
  3. LT1 auto-tuning tool (web based)
    By steveo in forum GM EFI Systems
    Replies: 3
    Last Post: 10-17-2014, 08:07 AM
  4. Narrowband o2 sensors all created equal?
    By Accrdwgnguy in forum GM EFI Systems
    Replies: 4
    Last Post: 12-19-2013, 12:46 AM
  5. TunerPro Rt used as a scan tool?
    By mudbuggy in forum TunerPro Tuning Talk
    Replies: 21
    Last Post: 01-10-2012, 03:38 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •