Bringing TBI and Multi Port Fuel Injection to a New Level.     EFI Conversions and Tuning! Seattle to Portland! E-mail Tuning Consultant!
Page 69 of 71 FirstFirst ... 19596465666768697071 LastLast
Results 1,021 to 1,035 of 1056

Thread: new $EE tuning thing!

  1. #1021
    Fuel Injected! steveo's Avatar
    Join Date
    Aug 2013
    Posts
    2,445
    Quote Originally Posted by kur4o View Post
    I tried the memo and it didn`t show up. Could it be because it needs a car connection or i broke something. I remember it was working correctly the last time I check it.
    yeah i broke the memo function somehow a few versions ago and nobody noticed, because nobody uses it. i could look over my github commits and try to figure out what did it.

    Do you think we can add m4 message to log file and make it playable.
    that's a great idea, i don't know why i ever thought of that

    it's possible but it's a lot of work. i might have to sit down this winter and do it, too many projects right now.

    one problem is the more you change your modified eehack, the more likely the changes i make wont work for you anymore. i guess i should be working on your source code and not mine

    i really want to make a 'normal' update to eehack without any of your experimental patches too, to fix some of the small bugs and crashes, the memo thing, etc.. the beta didn't work well for some people for some reason, i think it was the new version of qt and compiler i used...

  2. #1022
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    I use qt 5.6

    Here is the base source code I started with and the last good version I have modified.

    There is still small work needed. Fixing the patch side. It is slightly modified now.
    Adding CL m4 control. Cleaning some stuff and optimizing dashboard with some extra parameters.

    Things to do in future.

    Adding two more fields at the graph and making cursor to show the value at the bar. Adding more overlays with colour bars at top or bottom of the graph.

    If you have time a complete writeover with more modular object oriented design will be the best path to go. I am sure your skills vastly improved over time.

    I dont know about the memo but I am sure in the 4.7 it was working with the cyl balance test.
    Attached Files Attached Files

  3. #1023
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    Here is my latest work Closed loop control patch included.

    Provided eehack.exe contains v4 patch, so you can burn with it your favorite bin and enjoy all the extra stuff.

    Still in beta test. It wont brick your pcm, so if something dont work due to typo mistakes, you will be able to recover PCM.

    I hope someone do a test and report results.

    Some small details need to be worked out so it is not a final release yet.
    Attached Files Attached Files

  4. #1024

  5. #1025
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    I was thinking to fix some of the notes and forget to upload source.

    Ignore any wierd looking info.

    The closed loop control is as follow.

    02 int change the calculated value of table 26fb. The modifier adds or substract.
    02 swing changes left and right swing voltage, table 26f1.
    02 filter changes the left and right value of table 2700.

    All parameters are delta change +- and the conversion is taken from the eextra.xdf
    Attached Files Attached Files

  6. #1026
    Fuel Injected! spfautsch's Avatar
    Join Date
    Apr 2015
    Posts
    266
    Excellent work - it built for 64 bit linux on QT 5.10.1 with only one warning (an unused cylinder trim variable).

    Flashed without issue, started and ran. Logs attached.

    Edit: btw, I reverted back to a bin I was running back in May without any of your patches added manually.

    Is there anything in particular you'd like me to test? I played with #1 cylinder trim long enough to tell it was doing something then shut it down b/c I still haven't had a chance to fix my valve noise.

    One minor item I noticed on controller.ui - the sliders for VE control and all the CL paramaters have the tool tip info that was copied from the skew spark advance slider. I haven't read up on all the patches and wasn't clear on what the VE slider changes so didn't mess with it or the CL params b/c I didn't want to let it idle too long. The valve noise is nasty enough it's setting off the knock sensors, and I really don't want to trash the rocker arms I spent so much time and money building.
    Attached Files Attached Files

  7. #1027
    Fuel Injected! Terminal_Crazy's Avatar
    Join Date
    Oct 2015
    Location
    Lancashire England
    Posts
    236
    Quote Originally Posted by kur4o View Post
    I was thinking to fix some of the notes and forget to upload source.

    Ignore any wierd looking info.

    The closed loop control is as follow.

    02 int change the calculated value of table 26fb. The modifier adds or substract.
    02 swing changes left and right swing voltage, table 26f1.
    02 filter changes the left and right value of table 2700.

    All parameters are delta change +- and the conversion is taken from the eextra.xdf
    Hiya
    I downloaded it and tried to run it the other week but it complained about QT 5.xx something missing.
    Do I need to upgrade my QT version first?

    Mitch
    '95 Z28 M6 -Just the odd mod.
    '80 350 A3 C3 Corvette - recent addition.

  8. #1028
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    Did you put the exe file in the eehack instalation folder.

    This is only the exe file. You need to install 4.7 first and run the provided exe from there.

    spfautsch,

    Thanks for testing the patch and confirm that there is nothing broke in there. I hope you fix the engine soon and continue the ls1 coils mod work.
    I don`t want to risk your build and will test everything this weekend. Only thing that is still untested is the CL controls. Bench testing is also not possible since the routines need a running engine to execute.

    Now I work on improved version of the Open loop idle patch. The mode can be controlled via an external switch and there is mph threshold setting for entering open loop at zero tps, low mph. I also made an external switch to control sd/maf mode which can be combined with the loop switch and future expanded to some interesting power mode vs economy mode with different afr targets and other tables.

    Last thing that will be done is real time controlling for MAF pump shot table.

  9. #1029
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    Hi,
    Steveo

    I am trying to make a patch for real time maf table control.

    I need some help with eehack interface.
    I have a spin box that will input maf cell number, and a double spin box that will be new maf value for selected cell.
    A push button will send the new value with a single click, and one global enable switch.

    I still have no idea how to take the value of the spin box convert it to hex and point the value to a selected m4 byte.
    Worse part is the maf value needs to be double word in hex and controll two consecutive m4 bytes.

    If you can help with some direction I will be really gratefull.

    The closed loop control and Maf pump shot table control is almost done with some new parameters added and just needs some testing and fixing the patch portion of eehack, due to new stuff added.

  10. #1030
    Fuel Injected! steveo's Avatar
    Join Date
    Aug 2013
    Posts
    2,445
    if i understand correctly you need to get the low and high byte to throw them into the mode4 byte array. use some bitwise operators like this

    Code:
    uint16_t value = ui->your_spinbox->value();
    char low = value & 0xff;
    char high = (value >> 8) & 0xff;
    now you have the low and high order bytes seperate... so you can add them to the byte array

    construct_mode4[7] = high;
    construct_mode4[8] = low;

    this is the safest way, it's also possible to make a pointer to a 16 bit chunk of that array and just = the number, but i don't like that as much.

    if you want to present it as hex for a display or whatever, QString::number(value,16);

  11. #1031
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    Code:
    in mode4.cpp
    void datastream_control::m4_maf_value(int value, int cell){  
        char low = value & 0xff;
        char high = (value >> 8) & 0xff;
        m4_lock.lock();
        construct_mode4[20] = high;
        construct_mode4[21] = low;
        construct_mode4[18] = cell;
        m4_updated.request();
        m4_lock.unlock();
    }
    in controller.cpp
    void controller::on_maf_ram_btn_toggled(bool checked) {
        if(checked == true){
        uint16_t value = ui->maf_value->value() / 0.007813;
        int cell = ui->maf_cell->value();
        control->m4_maf_value(value, cell);
         update_m4_raw_display();
    }
    }
    Somehow I did managed to get to this result that worked.

    I am having troubles with the button now.
    I am struggling to make it to send the command while pressed and send nothing when released.

    Now it works only when toggled, and when untoggled keeps sending m4 command.


    edit:

    Will the eehack freak out if the seed is different on e and t side.
    Last edited by kur4o; 08-13-2018 at 06:38 AM.

  12. #1032
    Fuel Injected! steveo's Avatar
    Join Date
    Aug 2013
    Posts
    2,445
    the way it's supposed to work is you call m4_updated.request(); whenever you're done changing the mode 4 data, then it'll send it at the next available time slot. there's no way to send immediately, since all requests need to be queued so we can do simultaneous datalogging.

    why doesn't it stop sending? do you have your maf_ram_btn set to a toggle? are you thinking a click and hold then release thing? in your code above it looks like when you 'check' the button it should send once, and when you 'uncheck' it, nothing would happen.

  13. #1033
    Fuel Injected! steveo's Avatar
    Join Date
    Aug 2013
    Posts
    2,445
    Quote Originally Posted by kur4o View Post
    edit:

    Will the eehack freak out if the seed is different on e and t side.
    it should work fine, i planned for that (but never tested it). each side's key challenge/response is handled completely separately

  14. #1034
    Fuel Injected!
    Join Date
    Mar 2013
    Posts
    466
    on_maf_ram_btn_clicked() seems to work half way.
    When clicked it continously sends the command, until next click when it updates the new values if changed.

    It looks like mode4_construct needs special command to clear the bytes. It is also visible on the clear blms button. When clicked it continously sends the clear command until eehack is closed.

    I couldn`t find anything that works clicked vs unclicked or a bool settings.

    Might have to add another button that reset the settings.

  15. #1035
    Fuel Injected! steveo's Avatar
    Join Date
    Aug 2013
    Posts
    2,445
    i dont quite understand what you're trying to do, do you have a push button 'switch' to enable your maf thing, and then the controls will send updates when changed? or do you want to have a 'send' button that when you click it it sends the updates once?

    if you can't figure it out send me your source code and i'll play with it a bit

Similar Threads

  1. 1badcell and thats not the only thing
    By 1badcell in forum Introductions
    Replies: 2
    Last Post: 12-30-2013, 04:25 PM
  2. Replies: 6
    Last Post: 11-27-2012, 11:03 AM
  3. Replies: 2
    Last Post: 11-07-2012, 07:26 AM
  4. Minor thing.
    By historystamp in forum GearHead EFI Forum Support
    Replies: 7
    Last Post: 01-21-2012, 02:00 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •